OpenEphysBinaryRawIO: Fixing ttl multichan #1603
Merged
+74
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @vigji! Looking great! |
zm711
changed the title
|
Great, let me know if there's anything needed before merging! |
zm711
reviewed
Dec 3, 2024
zm711
previously approved these changes
Dec 3, 2024
alejoe91
reviewed
Dec 4, 2024
alejoe91
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1437.
Currently, all the logic in the events parser for OpenEphys data assumes that there is a single stream of events (simply positive or negative
states), and it breaks down when acquiring multiple digital signals at once (stateshaving different absolute values for different channels).This is a simple fix that looks for rising and falling edges separately for each of the digital channels.
Add simple testing relying on existing test data, which fails before the fix and passes afterwards.